-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kinesisanalytics-flink): add support for Flink 1.19 #30723
Conversation
@@ -21,21 +21,21 @@ describe('Application', () => { | |||
stack = new core.Stack(); | |||
bucket = new s3.Bucket(stack, 'CodeBucket'); | |||
requiredProps = { | |||
runtime: flink.Runtime.FLINK_1_11, | |||
runtime: flink.Runtime.FLINK_1_19, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: For future references, I would prefer to have this as parameterized tests to cover both existing and new runtime.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
Amazon Kinesis Data Analytics now supports Apache Flink v1.18 (LINK)
This is also supported in Cloudformation (LINK)
Description of changes
Runtime
typeChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license